Add compiler plugin completions in http service #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinthar
changed the title
TharmiganK
reviewed
Jul 6, 2023
...ugin-tests/src/test/java/io/ballerina/stdlib/http/compiler/AbstractLSCompilerPluginTest.java
Outdated
Show resolved
Hide resolved
...ugin-tests/src/test/java/io/ballerina/stdlib/http/compiler/AbstractLSCompilerPluginTest.java
Show resolved
Hide resolved
malinthar
force-pushed
the
add-cp-completions
branch
4 times, most recently
from
148679a
to
5b2336c
Compare
TharmiganK
reviewed
Jul 7, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1701 +/- ##
============================================
+ Coverage 81.55% 81.59% +0.04%
- Complexity 577 583 +6
============================================
Files 393 395 +2
Lines 21423 21437 +14
Branches 4796 4796
============================================
+ Hits 17471 17492 +21
+ Misses 2948 2946 -2
+ Partials 1004 999 -5
☔ View full report in Codecov by Sentry. |
malinthar
force-pushed
the
add-cp-completions
branch
from
629eca2
to
1cb5ac9
Compare
TharmiganK
reviewed
Jul 25, 2023
|
Functionality LGTM. |
dilanSachi
reviewed
Jul 26, 2023
...tests/src/test/java/io/ballerina/stdlib/http/compiler/completion/AbstractCompletionTest.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jul 26, 2023
compiler-plugin/src/main/java/io/ballerina/stdlib/http/compiler/completion/Constants.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jul 26, 2023
...c/main/java/io/ballerina/stdlib/http/compiler/completion/HttpServiceBodyContextProvider.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jul 26, 2023
...est/java/io/ballerina/stdlib/http/compiler/completion/ServiceDeclarationNodeContextTest.java
Outdated
Show resolved
Hide resolved
malinthar
force-pushed
the
add-cp-completions
branch
from
fd88704
to
70de0f2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ballerina-platform/ballerina-lang#40634
Examples
This PR implements a CompletionProvider in http compiler plugin which adds six new completion items for get, post, delete, put, head, and options http methods.
Checklist