Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Java 17 migration branch with master #502

Closed
wants to merge 22 commits into from
Closed

Sync Java 17 migration branch with master #502

wants to merge 22 commits into from

Conversation

gabilang
Copy link
Contributor

Purpose

Java 17 migration

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

gabilang and others added 17 commits June 22, 2023 19:02
@gabilang
Migrate to Java 17
f85f2b3
@warunalakshitha
Update bal gradle version
1bb553c
@warunalakshitha
Merge pull request #493 from gabilang/java_17_migration
0896fef 
Migrate to Java 17
@warunalakshitha
[Automated] Update the native jar versions
21e26da
@warunalakshitha
[Automated] Update the native jar versions
6bc0385
@warunalakshitha
Migrate to Java 17
64a6fbf
@warunalakshitha
Merge pull request #494 from warunalakshitha/java17-migration
37c2fbc 
Bump workflow actions
@warunalakshitha
[Automated] Update the native jar versions
68c1ac3
@gabilang @warunalakshitha
Disable failing tests temporarily
94ff721
@warunalakshitha
Disable falling test
5dbbc29
@warunalakshitha
[Automated] Update the native jar versions
287f951
@warunalakshitha
[Automated] Update the native jar versions
589a779
@warunalakshitha
[Automated] Update the native jar versions
51cf974
@warunalakshitha
[Automated] Update the native jar versions
573c2de
@gabilang
Fix oracle jdk download link
afa4b55
@gabilang
Change gradle version
c77bd1b
@gabilang
Merge pull request #499 from gabilang/fix-jdk-link
ccf197a 
Fix Oracle JDK download link
@gabilang gabilang changed the title Java 17 migration Sync Java 17 migration branch with master Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28% 🎉

Comparison is base (cb688c5) 85.43% compared to head (0f4d0de) 85.71%.

❗ Current head 0f4d0de differs from pull request most recent head 4e9041e. Consider uploading reports for the commit 4e9041e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #502      +/-   ##
============================================
+ Coverage     85.43%   85.71%   +0.28%     
+ Complexity       25       24       -1     
============================================
  Files            15       15              
  Lines           151      140      -11     
  Branches         32       32              
============================================
- Hits            129      120       -9     
+ Misses           20       18       -2     
  Partials          2        2
Files Changed Coverage Δ
...java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java 64.00% <100.00%> (-5.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabilang gabilang closed this Jul 26, 2023
@gabilang gabilang reopened this Jul 26, 2023
@warunalakshitha warunalakshitha force-pushed the java_17_migration branch 2 times, most recently from c9006ae to ab8d77b Compare July 27, 2023 06:07
warunalakshitha
warunalakshitha reviewed Jul 27, 2023
View reviewed changes
native/src/main/java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java Outdated
@@ -39,6 +39,10 @@ private SetEnv() {

}

static {
StaticComponentContainer.Modules.exportPackageToAllUnnamed("java.base", "java.util");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With java 17 we cannot use reflections of not exposed modules. either we need to pass --add-opens java.base/java.util=ALL-UNNAMED to java -jar command or programmatically do that using burningwave library

@warunalakshitha warunalakshitha force-pushed the java_17_migration branch 5 times, most recently from 0f4d0de to d4f8c29 Compare July 27, 2023 16:07
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
22.4% 22.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warunalakshitha warunalakshitha warunalakshitha left review comments

@daneshk daneshk Awaiting requested review from daneshk daneshk is a code owner

@MadhukaHarith92 MadhukaHarith92 Awaiting requested review from MadhukaHarith92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabilang @warunalakshitha