Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor environment variable handling #505

Conversation

warunalakshitha
Copy link
Contributor

@warunalakshitha warunalakshitha commented Aug 2, 2023

Purpose

$Subject

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.03% 🎉

Comparison is base (60e6ef5) 86.30% compared to head (608630b) 91.33%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #505      +/-   ##
============================================
+ Coverage     86.30%   91.33%   +5.03%     
+ Complexity       26       25       -1     
============================================
  Files            16       16              
  Lines           146      127      -19     
  Branches         36       32       -4     
============================================
- Hits            126      116      -10     
+ Misses           18       10       -8     
+ Partials          2        1       -1     
Files Changed Coverage Δ
...java/io/ballerina/stdlib/os/nativeimpl/GetEnv.java 100.00% <100.00%> (ø)
...ava/io/ballerina/stdlib/os/nativeimpl/ListEnv.java 100.00% <100.00%> (+81.81%) ⬆️
...java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java 100.00% <100.00%> (ø)
...ain/java/io/ballerina/stdlib/os/utils/OSUtils.java 95.23% <100.00%> (+5.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 17, 2023
@warunalakshitha warunalakshitha merged commit c9849ae into ballerina-platform:master Aug 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants