Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maximum sql pool size configurable #723

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Make maximum sql pool size configurable #723

merged 7 commits into from
Jul 12, 2024

Conversation

aashikam
Copy link
Contributor

Purpose

Fixes:

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a 2201.8.x branch and change the base to that branch.

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the branch, LGTM.

@aashikam aashikam changed the base branch from v1.12.x to 2201.8.x July 12, 2024 04:59
Copy link

sonarcloud bot commented Jul 12, 2024

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (2201.8.x@1b95f51). Learn more about missing BASE report.

Files Patch % Lines
...ina/stdlib/sql/datasource/SQLWorkerThreadPool.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             2201.8.x     #723   +/-   ##
===========================================
  Coverage            ?   80.07%           
  Complexity          ?      109           
===========================================
  Files               ?       45           
  Lines               ?     4006           
  Branches            ?      754           
===========================================
  Hits                ?     3208           
  Misses              ?      541           
  Partials            ?      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashikam aashikam merged commit 2dea956 into 2201.8.x Jul 12, 2024
3 checks passed
@aashikam aashikam deleted the pool branch July 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants