Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zendesk and asana connectors #835

Merged
merged 2 commits into from
May 9, 2024

Conversation

NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe commented Apr 10, 2024

Description

$subject, as Zendesk and Asana connectors are moved out and will be maintained under dedicated repositories (along with the new connector reviving effort)

Related to ballerina-platform/ballerina-library#6185 and ballerina-platform/ballerina-library#6238

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Ballerina Version:
  • Operating System:
  • Java SDK:

Checklist:

Changes to OpenAPI definition

  • Modified info section of the OpenAPI definition file - Example

    • description - what the connector is about
    • x-ballerina-init-description OpenAPI extension - connector initialization details
    • x-ballerina-display OpenAPI extension - connector name and path to the connector icon
  • Added proper description each API Key, if API Key authentication is defined in OpenAPI definition file

Changes to connector module

  • Added license header at the top of each .bal file.
  • Added Package.md as per the guide here
  • Added Module.md for the module of the connector as per the guide here
  • Added connector icon to the root of the connector. Icon needs to be a png of 200x200 px size with name icon.png
  • Added Ballerina.toml file with following information. For keywords refer to guide

Verifying connector module

  • Compiled the connector successfully with the targeted ballerina version.
  • Conducted smoke tests on the connector (Recommended when OpenAPI definition is obtain from an unofficial source)

Security checks

# Zendesk connector will be maintained as a standalone module under https://github.com/ballerina-platform/module-ballerinax-zendesk
# Asana connector will be maintained as a standalone module under https://github.com/ballerina-platform/module-ballerinax-asana
@NipunaRanasinghe NipunaRanasinghe marked this pull request as ready for review April 25, 2024 07:35
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NipunaRanasinghe NipunaRanasinghe merged commit bd0a79a into ballerina-platform:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants