Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set album and file extension before generating filename #107

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

krankydonkey
Copy link

Edited downloader.js to move the parseData and selectedFormat calls to above the generatePath call.

Copy link

changeset-bot bot commented Sep 22, 2024

⚠️ No Changeset found

Latest commit: 172c331

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bambanah
Copy link
Owner

bambanah commented Oct 1, 2024

The original motivation behind this behaviour was primarily for fast skipping tracks that are already downloaded since the parseData call is extremely expensive. Since I only download mp3 with basic %artist% - %title% format I didn't pick up on these issues.

File integrity definitely comes before speed, so will merge this and think of a much smarter way to skip downloads.

@bambanah bambanah merged commit 403c7a0 into bambanah:main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants