Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop running Android FPS detection on flashlight start #321

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: stop running Android FPS detection on flashlight start #321

wants to merge 4 commits into from

Conversation

Almouro
Copy link
Member

@Almouro Almouro commented Oct 3, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for flashlight-docs canceled.

Name Link
🔨 Latest commit 24af210
🔍 Latest deploy log https://app.netlify.com/sites/flashlight-docs/deploys/66fea12516c2ac0008fa380f

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@Almouro Almouro marked this pull request as ready for review October 3, 2024 14:52
@Almouro
Copy link
Member Author

Almouro commented Oct 3, 2024

Just changed some small things so that flashlight doesn't try to retrieve FPS just on start

@MalcolmTomisin would you able to take a look by any chance? 🙏

@MalcolmTomisin
Copy link
Contributor

Sure!

MalcolmTomisin
MalcolmTomisin approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@MalcolmTomisin MalcolmTomisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for improving this. Really appreciate the deeper insight into how all the moving parts work together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalcolmTomisin MalcolmTomisin MalcolmTomisin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Almouro @flashlight-bot @MalcolmTomisin