Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #44

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Fix CI #44

merged 4 commits into from
Apr 24, 2024

Conversation

dvic
Copy link
Collaborator

@dvic dvic commented Apr 15, 2024

No description provided.

@dvic
Copy link
Collaborator Author

dvic commented Apr 15, 2024

@bamorim It looks like Code.Typespec.fetch_types(bytecode) returns :error? (TypedEctoSchemaTest.standardise/2 is being fed nil) Any idea why?

@bamorim
Copy link
Owner

bamorim commented Apr 15, 2024

That's a private module that IIRC we were only using for tests (I hope). This also means that it can break xD.

That being said, maybe the compilation is not including typespecs by default and we need to set an option for that?

@bamorim
Copy link
Owner

bamorim commented Apr 15, 2024

Maybe something changed in Elixir 1.14?

@bamorim
Copy link
Owner

bamorim commented Apr 15, 2024

What does :beam_lib.info(beam_bytecode) returns?

@bamorim
Copy link
Owner

bamorim commented Apr 15, 2024

Found this that seems to be related

https://elixirforum.com/t/enable-abstract-code-chunk-in-elixir-1-14/52514

@bamorim
Copy link
Owner

bamorim commented Apr 15, 2024

Which points to elixir-lang/elixir#12300

Sorry for all the messages, on my phone right now.

Need to go to bed now xD

@dvic dvic merged commit 9678ea0 into master Apr 24, 2024
9 checks passed
@dvic dvic deleted the fix-ci branch April 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants