delete legacy PM example and usage #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found some check errors, and I'm not sure if it's related to me. I just deleted the legacy PM-related content from the hello world code, and my local tests (in the Ubuntu 22.04 environment) were successful. This is my first time submitting a PR. I apologize if there are any issues causing trouble. @banach-space |
|
No apology required - your contribution is benefiting us all and is greatly appreciated 🙏🏻 . The pre-commit CI for llvm-tutor looks good. The failing jobs are due to the recent update to LLVM 17 (i.e. unrelated to this change). Thanks for seeing this through and responding so promptly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously submitted a pull request, and after discussing with you, we reached an agreement to remove the legacy usage and example. However, multiple commits from me resulted in a confusing submission. I have made the necessary changes and resubmitted the pull request.