Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jump out for oauth with login #637

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

everpcpc
Copy link
Contributor

@everpcpc everpcpc commented May 19, 2024

现在登录后的转跳会使用 window.location.replace ,不再使用 history.push,允许转跳出SPA。

Copy link
Contributor

github-actions bot commented May 19, 2024

Preview Deployment

Build URL time
Sites netlify preview 2024-04-00 14:49:25Z
Storybook netlify preview 2024-04-00 14:50:16Z

@trim21
Copy link
Contributor

trim21 commented May 19, 2024

没必要硬编码吧,一律用 window.location.replace 就好,登录也不是什么高频操作。

@mergify mergify bot added the waiting-approval waiting code reviewers to approval PR label May 19, 2024
@everpcpc
Copy link
Contributor Author

对于 react 内部的跳转用 window.location.replace 也不太合适?

@trim21
Copy link
Contributor

trim21 commented May 19, 2024

这个转跳只会在登录的时候发生一次,我觉得是没必要硬编码

@everpcpc
Copy link
Contributor Author

倒也是

@mergify mergify bot added ci:test:fail and removed waiting-approval waiting code reviewers to approval PR labels May 19, 2024
@everpcpc
Copy link
Contributor Author

everpcpc commented May 19, 2024

这个跳转还加了 test TAT
要不就还是单独处理吧……

@mergify mergify bot added waiting-approval waiting code reviewers to approval PR and removed ci:test:fail labels May 19, 2024
@trim21
Copy link
Contributor

trim21 commented May 19, 2024

感觉不太好吧(

@mergify mergify bot added ci:test:fail and removed waiting-approval waiting code reviewers to approval PR labels May 19, 2024
@everpcpc everpcpc force-pushed the fix-jump branch 2 times, most recently from 80e368d to 87012a7 Compare May 19, 2024 14:40
@mergify mergify bot removed the ci:test:fail label May 19, 2024
@everpcpc
Copy link
Contributor Author

应该好了……

@mergify mergify bot added the waiting-approval waiting code reviewers to approval PR label May 19, 2024
@mergify mergify bot added waiting-opened-48h PR will be merged by bot after it's opened 48h and removed waiting-opened-48h PR will be merged by bot after it's opened 48h labels May 19, 2024
@mergify mergify bot merged commit c102a69 into bangumi:master May 21, 2024
9 checks passed
@everpcpc everpcpc deleted the fix-jump branch May 21, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS waiting-approval waiting code reviewers to approval PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants