-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jump out for oauth with login #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Deployment
|
没必要硬编码吧,一律用 |
对于 react 内部的跳转用 |
这个转跳只会在登录的时候发生一次,我觉得是没必要硬编码 |
倒也是 |
mergify
bot
added
ci:test:fail
and removed
waiting-approval
waiting code reviewers to approval PR
labels
May 19, 2024
这个跳转还加了 test TAT |
mergify
bot
added
waiting-approval
waiting code reviewers to approval PR
and removed
ci:test:fail
labels
May 19, 2024
感觉不太好吧( |
mergify
bot
added
ci:test:fail
and removed
waiting-approval
waiting code reviewers to approval PR
labels
May 19, 2024
everpcpc
force-pushed
the
fix-jump
branch
2 times, most recently
from
May 19, 2024 14:40
80e368d
to
87012a7
Compare
应该好了…… |
trim21
approved these changes
May 19, 2024
cokemine
approved these changes
May 19, 2024
mergify
bot
added
waiting-opened-48h
PR will be merged by bot after it's opened 48h
and removed
waiting-opened-48h
PR will be merged by bot after it's opened 48h
labels
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现在登录后的转跳会使用
window.location.replace
,不再使用history.push
,允许转跳出SPA。