Fix bugs and re-enable unit tests. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: 1. Remove dependency upon Make executable. 2. Fix "absolute file paths" issue baniol#3. 3. Fix "tests are broken" issue baniol#4. 4. Update "test/My Clippings.txt" with snippet of the format dumped from my Kindle Paperwhite 300ppi (as of 2017-06-10) 5. Fixed bug around parsing book titles with parentheses in them. 6. Updated date parsing; added 'moment.js' dependency. 7. Removed some dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I was trying to dump my Kindle "My Clippings.txt" output in a cleaner format and found your script. It came very close to getting it right. I put together some tweaks that made it work for me.
Thanks,
David
Changelog:
dumped from my Kindle Paperwhite 300ppi (as of 2017-06-10)