Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about anyCastPort and ingressControllerTargetPort #123

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

panyuenlau
Copy link
Member

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Corresponding docs for banzaicloud/koperator#997

Why?

Add docs for the new feature and existing functionality

@panyuenlau panyuenlau requested review from a team and fekete-robert June 16, 2023 19:08
fekete-robert
fekete-robert previously approved these changes Jun 17, 2023
pregnor
pregnor previously approved these changes Jun 20, 2023
docs/external-listener/index.md Outdated Show resolved Hide resolved
docs/external-listener/index.md Outdated Show resolved Hide resolved
docs/external-listener/index.md Outdated Show resolved Hide resolved
@panyuenlau panyuenlau dismissed stale reviews from pregnor and fekete-robert via 19078cf June 20, 2023 18:32
@panyuenlau
Copy link
Member Author

@pregnor @fekete-robert We shouldn't merge this before the next Koperator release is dropped, right?

@pregnor
Copy link
Member

pregnor commented Jun 21, 2023

@pregnor @fekete-robert We shouldn't merge this before the next Koperator release is dropped, right?

I guess so, but I'm lost what is auto-released and what is not so I defer to Robi's answer.

@panyuenlau
Copy link
Member Author

@pregnor @fekete-robert We shouldn't merge this before the next Koperator release is dropped, right?

I guess so, but I'm lost what is auto-released and what is not so I defer to Robi's answer.

yea... I started to think that we might need to use release tag, so that committing to master branch wouldn't make the commit public

@fekete-robert
Copy link
Member

@pregnor @panyuenlau : Stuff from the master branch is not published automatically, but new merges automatically open PR for the banzai site. So we can either mark the PR with something like Do not merge until X.Y release, or we can merge it, and then I'll (hopefully) keep in mind that we shouldn't publish updates to the koperator docs on the banzai site.

This will improve when we migrate the docs and the code to the new github org, where we can have versioned docs, and have a separate set for version X.Y, and also a latest greatest build from the main branch.

@panyuenlau panyuenlau changed the title Add notes about anyCastPort and ingressControllerTargetPort [Do not merge until Koperator v0.25.0] Add notes about anyCastPort and ingressControllerTargetPort Jun 30, 2023
@panyuenlau panyuenlau changed the title [Do not merge until Koperator v0.25.0] Add notes about anyCastPort and ingressControllerTargetPort Add notes about anyCastPort and ingressControllerTargetPort Jul 12, 2023
@panyuenlau panyuenlau merged commit e7aa887 into master Jul 12, 2023
@panyuenlau panyuenlau deleted the external-listener/wellknown-port branch July 12, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants