Added Koperator e2e test - external consumer producer #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
force-pushed
the
test/de2e-koperator-externalCP
branch
from
efb3ee4
to
4cd451f
Compare
Kuvesz
reviewed
Jun 7, 2023
tests/e2e/kafka_prod_consum_test.go
Outdated
| // requireExternalProducerConsumer deploys a kafkaTopic into the K8s cluster | ||
| // and produces, consumes messages and makes comparison between the produced and consumed messages. | ||
| func requireExternalProducerConsumer(kubectlOptions *k8s.KubectlOptions) { | ||
| When("Externally produce and consume message to Kafka cluster", Ordered, func() { |
There was a problem hiding this comment.
Suggested change
| When("Externally produce and consume message to Kafka cluster", Ordered, func() { | |
| When("Externally produce and consume message to and from the Kafka cluster", Ordered, func() { |
tests/e2e/kafka_prod_consum_test.go
Outdated
|
|
||
| for i := range messages { | ||
| record := &kgo.Record{Topic: topicName, Value: []byte(messages[i])} | ||
| // Exists at the first error occurrence |
There was a problem hiding this comment.
Suggested change
| // Exists at the first error occurrence | |
| // Exits at the first error occurrence |
tests/e2e/kafka_prod_consum_test.go
Outdated
Comment on lines
180
to
181
| // This check may fail when the topic is re-created and has some undeleted content. | ||
| Expect(consumedMessages).Should(HaveLen(1)) |
There was a problem hiding this comment.
Do we need this check in this case? We might end up reusing stuff in the end. Instead we could just compare with the last message from what we consumed here I think.
There was a problem hiding this comment.
Will we actually run into this case that " the topic is re-created and has some undeleted content" in the test environment? If not, I think it's better to remove that comment to avoid confusions
There was a problem hiding this comment.
Ok I will remove it.
tests/e2e/kafka_prod_consum_test.go
Outdated
| } | ||
|
|
||
| // requireExternalProducingConsumingMessage gets the Kafka cluster external addresses from the kafkaCluster CR status | ||
| // when externalAddresses is not specified and producing, consuming messages and make comparison between them. |
There was a problem hiding this comment.
Suggested change
| // when externalAddresses is not specified and producing, consuming messages and make comparison between them. | |
| // when externalAddresses is not specified. It also produces and consumes messages and makes a comparison between them. |
panyuenlau
previously approved these changes
Jun 7, 2023
bartam1
force-pushed
the
test/de2e-koperator-uninstall
branch
from
b905456
to
56b6b8a
Compare
bartam1
force-pushed
the
test/de2e-koperator-externalCP
branch
from
4cd451f
to
3071ef6
Compare
bartam1
force-pushed
the
test/de2e-koperator-uninstall
branch
from
1a732a8
to
46b2d71
Compare
bartam1
force-pushed
the
test/de2e-koperator-externalCP
branch
from
d029f87
to
0e03f84
Compare
pregnor
previously approved these changes
Jun 20, 2023
pregnor
approved these changes
Jun 22, 2023
Kuvesz
approved these changes
Jun 22, 2023
tests/e2e/kafka.go
Outdated
| kafkaTopicTemplate, | ||
| map[string]interface{}{ | ||
| "Name": topicName, | ||
| "TopicName": topicName, | ||
| "Namespace": kubectlOptions.Namespace, | ||
| }, | ||
| ) | ||
| err := waitK8sResourceCondition(kubectlOptions, kafkaTopicKind, "jsonpath={.status.state}=created", defaultTopicCreationWaitTime, "", topicName) | ||
| Expect(err).ShouldNot(HaveOccurred()) |
There was a problem hiding this comment.
I still think we should refactor these later on to be the same across our code base, but I don't think this should block merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding basic end to end tests for Koperator.
Included tests:
Type of Change
Checklist