Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HIS): add PARAM his metric #72

Open
wants to merge 1 commit into
base: wip/his-metrics
Choose a base branch
from
Open

feat(HIS): add PARAM his metric #72

wants to merge 1 commit into from

Conversation

AfonsoSantos96
Copy link
Member

@AfonsoSantos96 AfonsoSantos96 commented Nov 7, 2023 •
edited by danielRep
Loading

This PR introduces the feature of checking if there are more than 5 function parameters on its signature.
For this check, the cflow tool is used.

Edited by @danielRep :
To test with https://github.com/bao-project/bao-his-tests just run the command make ci METRIC=param.

Checklist:

  • Tested using the bao-his-tests repo on branch.
  • The changes generate no new warnings when building the project. If so, I have justified above.
  • I have run the CI checkers before submitting the PR to avoid unnecessary runs of the workflow.

@AfonsoSantos96 AfonsoSantos96 mentioned this pull request Nov 7, 2023
Open
1 task
@AfonsoSantos96 AfonsoSantos96 force-pushed the feat/his_parameters branch 2 times, most recently from 58dd7e3 to 3ac6b14 Compare November 9, 2023 16:49
@danielRep danielRep self-assigned this Nov 10, 2023
danielRep
danielRep requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@danielRep danielRep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and LGTM.

his_checker.py Outdated Show resolved Hide resolved
@AfonsoSantos96 AfonsoSantos96 force-pushed the feat/his_parameters branch 2 times, most recently from a99acac to 8c1f173 Compare November 10, 2023 12:14
danielRep
danielRep previously approved these changes Nov 10, 2023
View reviewed changes
@josecm josecm self-assigned this Feb 16, 2024
@AfonsoSantos96 AfonsoSantos96 dismissed danielRep’s stale review February 23, 2024 12:25

The merge-base changed after approval.

@danielRep danielRep force-pushed the wip/his-metrics branch 3 times, most recently from e298879 to 27fec24 Compare February 27, 2024 11:28
@danielRep
Copy link
Member

Updated with the modifications introduced in #68 and changed the output format.

@danielRep
Copy link
Member

@miguelafsilva5 @josecm
Use the testing repo (https://github.com/bao-project/bao-his-tests) has a dummy testbed for each individual metric verified by the HIS checker.
You only need to clone the repo, checkout the ci to this branch, and then make ci METRIC=param.

@miguelafsilva5
Copy link
Member

From my testing, it seems to be working as intended.

@danielRep danielRep changed the title feat(HIS): add number of function parameters check to script feat(HIS): add PARAM his metric Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelafsilva5 miguelafsilva5 miguelafsilva5 approved these changes

@danielRep danielRep danielRep left review comments

@josecm josecm Awaiting requested review from josecm josecm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@josecm josecm

@danielRep danielRep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AfonsoSantos96 @danielRep @miguelafsilva5 @josecm