Fix(rv32_conversions): Fix errors with literal sizes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling for RV32, the expected size of the argument used is 32-bit. Using 1ULL forces the argument to be 64-bit since shift operations take the size of the largest operand. This results in the error Werror=arith-conversion when compiling for RV32 Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
josecm
approved these changes
Oct 14, 2024
ninolomata
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The PR #117 introduced some compiling errors for riscv32 builds.
This PR fixes those errors, which were related to using 64-bit literals for operations/functions that needed 32-bit values.