fix(aarch32/sysregs): fix the 64-bit register read function #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecm
requested changes
Oct 15, 2024
AfonsoSantos96
force-pushed
the
fix/sysregs
branch
from
5db8505
to
bcd9d28
Compare
miguelafsilva5
previously approved these changes
Oct 15, 2024
Signed-off-by: Afonso Santos <[email protected]>
AfonsoSantos96
force-pushed
the
fix/sysregs
branch
from
bcd9d28
to
a4f501f
Compare
josecm
approved these changes
Oct 16, 2024
miguelafsilva5
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
unsigned long longfor both variables may introduce unexpected values in the OR operation in the return statement, as the_tempvariable is not guaranteed to be initialized to 0.