Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sipreg/reg.c: stop retrying registers early after 401/407 #1143

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

maximilianfridrich
Copy link
Contributor

Currently, REGISTERs are retried until the loop detection mechanism kicks in, which results in 16 unsuccessful REGISTERs being sent in very quick succession if the REGISTER can't be authorized (401 or 407 responses).

Now, on 401 and 407 responses, the REGISTER is only retried once (instead of 16 times). Re-trying the same request 16 times with the same auth credentials doesn't make much sense.

@sreimers sreimers added this to the v3.14.0 milestone Jun 14, 2024
@sreimers sreimers merged commit 1bf05d8 into baresip:main Jun 19, 2024
38 checks passed
@maximilianfridrich maximilianfridrich deleted the registration_early_fail branch June 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants