httpauth: basic challenge creation and verification functions #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cHuberCoffee
commented
Jul 10, 2023
cHuberCoffee
commented
- create and encode HTTP Basic requests.
- verify HTTP basic authentication header
- test cases for httpauth_basic verification and request encoding
- httpauth_basic is tested against wget, curl and an chromium based browser (Brave Browser)
sreimers
reviewed
Jul 10, 2023
alfredh
reviewed
Jul 11, 2023
src/httpauth/basic.c
Outdated
| if (!req) | ||
| return 0; | ||
|
|
||
| if (req->charset && str_len(req->charset)) |
There was a problem hiding this comment.
it is better to use "str_isset" here
alfredh
reviewed
Jul 11, 2023
src/httpauth/basic.c
Outdated
| return re_hprintf(pf, "Basic realm=\"%s\", charset=\"%s\"", | ||
| req->realm, req->charset); | ||
| else | ||
| return re_hprintf(pf, "Basic realm=\"%s\"", req->realm); |
There was a problem hiding this comment.
this code can be simplified.
Print "basic realm" every time. If charset is set, append charset.
alfredh
reviewed
Jul 11, 2023
src/httpauth/basic.c
Outdated
| goto out; | ||
|
|
||
| err = mbuf_printf(mb, "%b:%b", | ||
| user, str_len(user), passwd, str_len(passwd)); |
There was a problem hiding this comment.
can also use %s:%s here ...
alfredh
reviewed
Jul 11, 2023
src/httpauth/basic.c
Outdated
| if (err) | ||
| goto out; | ||
|
|
||
| if (memcmp(mb->buf, c, clen) != 0) |
There was a problem hiding this comment.
it is more secure to use this function:
int mem_seccmp(const uint8_t *s1, const uint8_t *s2, size_t n);
|
looks good. Please merge to main... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.