aufile: add methods to get size in bytes/length in ms #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreimers
reviewed
Aug 18, 2023
|
Thanks for the PR, looks good, only the return err cases should be better Edit: And some linter (ccheck) warnings, need to be fixed: ./rem/aufile/aufile.c:263: line is too wide (80 - max 79)
./rem/aufile/aufile.c:265: line is too wide (84 - max 79)
./rem/aufile/aufile.c:267: line is too wide (84 - max 79)
./rem/aufile/aufile.c:270: line is too wide (84 - max 79) |
sreimers
reviewed
Aug 18, 2023
Co-authored-by: Sebastian Reimers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create two new functions:
aufile_get_size()aufile_get_length()The former returns the size in bytes, the latter the length in milliseconds.