Skip to content

Commit

Permalink
pythonGH-110109: Test pure functionality of pathlib.Path user subcl…
Browse files Browse the repository at this point in the history
…asses

Add `PurePathTest` as a superclass of `PathTest`, and therefore also
`PathSubclassTest`. This adds coverage of pure functionality in user
subclasses of `pathlib.Path`.

Remove `PosixPathAsPureTest` and `WindowsPathAsPureTest`, as they
now duplicate `PosixPathTest` and `WindowsPathTest`.

This makes the MROs of test unit classes match the MROs of pathlib
classes.
  • Loading branch information
barneygale committed Nov 18, 2023
1 parent 9c7c8ba commit d4d0960
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions Lib/test/test_pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1569,15 +1569,6 @@ class cls(pathlib.PurePath):
test_repr_roundtrips = None


@only_posix
class PosixPathAsPureTest(PurePosixPathTest):
cls = pathlib.PosixPath

@only_nt
class WindowsPathAsPureTest(PureWindowsPathTest):
cls = pathlib.WindowsPath


#
# Tests for the virtual classes.
#
Expand Down Expand Up @@ -1771,6 +1762,7 @@ class DummyPathTest(unittest.TestCase):
#

def setUp(self):
super().setUp()
pathmod = self.cls.pathmod
p = self.cls(BASE)
p.mkdir(parents=True)
Expand Down Expand Up @@ -2793,7 +2785,7 @@ class DummyPathWithSymlinksTest(DummyPathTest):
# Tests for the concrete classes.
#

class PathTest(DummyPathTest):
class PathTest(DummyPathTest, PurePathTest):
"""Tests for the FS-accessing functionalities of the Path classes."""
cls = pathlib.Path
can_symlink = os_helper.can_symlink()
Expand Down Expand Up @@ -3409,7 +3401,7 @@ def test_walk_many_open_files(self):


@only_posix
class PosixPathTest(PathTest):
class PosixPathTest(PathTest, PurePosixPathTest):
cls = pathlib.PosixPath

def test_absolute(self):
Expand Down Expand Up @@ -3585,7 +3577,7 @@ def test_from_uri_pathname2url(self):


@only_nt
class WindowsPathTest(PathTest):
class WindowsPathTest(PathTest, PureWindowsPathTest):
cls = pathlib.WindowsPath

def test_absolute(self):
Expand Down

0 comments on commit d4d0960

Please sign in to comment.