Skip to content

Commit

Permalink
Test a rollup again if one of the PRs advances, without the advanced PR
Browse files Browse the repository at this point in the history
  • Loading branch information
barosl committed Dec 15, 2014
1 parent 7d95f54 commit 416f6cc
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions bors.py
Original file line number Diff line number Diff line change
Expand Up @@ -566,17 +566,19 @@ def advance_master_ref_to_test(self, pulls):
if self.batched():
num2sha = {x.num: x.sha for x in pulls}

error_occurred = False

advanced = False
for num, sha in self.metadata['rollup_pulls']:
if num2sha[num] != sha:
error_occurred = True
advanced = True

msg = '#{} advanced, cannot continue'.format(num)
msg = '#{} advanced, testing again without the PR'.format(num)
self.log.info(msg)
self.add_comment(self.sha, msg)
self.set_error(msg)

if error_occurred: return
if advanced:
self.statuses = [x for x in self.statuses if x not in ['success', 'pending']] # Mark this PR as unsuccessful
self.merge_or_batch(pulls)
return

s = ("fast-forwarding %s to %s = %.8s" %
(self.master_ref, self.test_ref, self.metadata['merge_sha']))
Expand Down

0 comments on commit 416f6cc

Please sign in to comment.