Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Laravel-specific code #320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jnoordsij
Copy link

@jnoordsij jnoordsij commented Jan 30, 2023

This PR aimed to add support for Laravel 10, which was later introduced in #321.

It's remaining parts is refactoring some things to allow for easier static code analysis within IDE, to allow spotting deprecations and/or removals from Laravel more easily. It also specifically lists all used Illuminate dependencies in composer.json.

ToDo:

  • Actually test this on a real life Laravel application, as there is no test suite

@barryvdh
Copy link
Owner

barryvdh commented Feb 5, 2023

Thanks, did you get a chance to test this? Are the changes required or can we bump the versions for now?

@barryvdh
Copy link
Owner

barryvdh commented Feb 5, 2023

I've tagged a versions which allows Laravel 10, but will consider this as an improvement.

@jnoordsij jnoordsij force-pushed the add-laravel10-support branch from 61a8900 to 37a77d8 Compare February 5, 2023 18:50
@jnoordsij jnoordsij marked this pull request as ready for review February 5, 2023 18:58
@jnoordsij jnoordsij changed the title Add Laravel 10 support Refactor Laravel-specific code Feb 5, 2023
@jnoordsij
Copy link
Author

@barryvdh thanks for looking into this! I wasn't able to test this in my application yet, but a quick test round in a fresh Laravel skeleton allowed me to publish everything and use basic operations without any problems. So I think the Laravel 10 support is good to go!

I've rebased my branch so you can still merge in the changes. You're correct none of them are actually required for Laravel 10, they basically were the easiest way for me to check basic compatibility in terms of classes/functions using just an IDE. Nonetheless I think they're very useful to keep this package up to date ;)

@jnoordsij
Copy link
Author

Subtle reminder this is still open; if there is anything I can do here, let me know!

Also refactor some cases where $this->app could be used and use constructor property promotion
Also sort dependencies for better readability
@jnoordsij jnoordsij force-pushed the add-laravel10-support branch from 37a77d8 to 6e5bba0 Compare April 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants