Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send local games states notifications on start (do not rely on whether Galaxy call get_local_games) #47

Merged
merged 6 commits into from
Jan 29, 2021

Conversation

bartok765
Copy link
Owner

@bartok765 bartok765 commented Jan 28, 2021

Fixes #44

  • removes boolean that prevented local game states notification if get_local_games was not called at least once (I don't know what was the initial purpose of this logic). Instead start watching local files and registry after handshake_complete method is called. Before this method is called all notifications about local game statuses are ignored by Galax
  • add tests for update_local_game_status notifications
  • remove redundant notification with LocalGameState.None_ when not-fully installed and not playable game is detected

@bartok765 bartok765 merged commit 1a1c1d8 into master Jan 29, 2021
@bartok765 bartok765 deleted the notify_about_local_games branch May 5, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Games shown as not installed
1 participant