Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish arm64 Docker images #190

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Publish arm64 Docker images #190

merged 5 commits into from
Feb 23, 2024

Conversation

mikery
Copy link
Contributor

@mikery mikery commented Feb 5, 2024

This PR updates the Docker workflow to provide linux/arm64 images.

Example workflow execution: https://github.com/mikery/base-node/actions/runs/7773045091/job/21196224081

@wbnns
Copy link
Member

wbnns commented Feb 5, 2024

@mikery

Thanks for the PR! Adding this to the backlog for the team to review. 👍

@wbnns wbnns added the state: backlog This is pending further review label Feb 5, 2024
@Mitsuwa
Copy link
Contributor

Mitsuwa commented Feb 9, 2024

Please include these updates to the pr.yaml workflow that runs on pr as well to ensure both arch's are also tested on pr's

@Mitsuwa
Copy link
Contributor

Mitsuwa commented Feb 9, 2024

Using a matrix here instead of listing both arch's to buildx will allow the builds to run concurrently and it will be clearer which arch is failing if there is a difference in archs, because they will separate into different jobs, something like

image

this will also make it easier in the future to configure any additional steps for the arch if there is ever a need to

@mdehoog
Copy link
Contributor

mdehoog commented Feb 22, 2024

Unfortunately I cannot push to your branch, so I added support for the PR tests here: mikery#1. Please merge this, and then we can merge this PR.

Alternatively I'll close this PR and open a separate one with the same changes.

Add multi-arch build to PR action
@mikery
Copy link
Contributor Author

mikery commented Feb 23, 2024

@mdehoog thanks for the updates, and apologies for the slow response. I've merged your branch into mine.

Copy link
Contributor

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mdehoog mdehoog merged commit af5a6b7 into base-org:main Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: backlog This is pending further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants