-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #1072
base: main
Are you sure you want to change the base?
Fix CI #1072
Conversation
d1b89b8
to
e1b2fda
Compare
d89ec5e
to
6a9d7b0
Compare
c1b7456
to
bed325a
Compare
bed325a
to
d536282
Compare
After more investigation, I believe the issue is that forks do not inherit repository secrets:
This means that contributors submitting pull requests are executing their own suites in their own CI environments without access to Do contributors need to register their own accounts and get their own secrets? |
Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub actions instance if But there must be something else going on. The test randomly fail some times even when the |
Allows forks to run tests on GitHub Actions without having to have access to the SauceLabs secret. Ref. #1072 (comment)
Allows forks to run tests on GitHub Actions without having to have access to the SauceLabs secret. Ref. #1072 (comment)
@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to an |
Test against the latest browser and OS versions. Android 9 is EOLed, test instead against Android 11 which is the oldest version still receiving updates.
Also test the latest Safari version.