Pass invoking element as event data #1112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given toolbar buttons that triggers an external action like:
Trix will call
trix-action-invoke
withevent.actionName
ofx-insert-token
.We can register behavior to handle this event:
But only the
actionName
is sent inevent
, there appears to be no way to get a reference to the invoking element. In this case, we need that reference to read thedata-token
attribute so we could then write:This PR changes
invokeAction
to pass along theinvokingElement
for toolbar external actions.Currently, you can work around this by using something like Stimulus to process the button click as an action and then get a reference to the Trix editor instance, but this change would support this kind of extension directly using Trix primitives and concepts.
I did not see any tests around this event functionality so I have omitted them. Happy to take a stab if that helps!