Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with dictation on iOS 18+ #1191

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix bug with dictation on iOS 18+ #1191

merged 2 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Fix bug with dictation on iOS 18+ 

    Dictation on iOS does not trigger composition events (https://bugs.webkit.org/show_bug.cgi?id=261764). Instead, it
triggers `beforeinput` events with `insertText`. During the dictation phase, it keeps the range anchored to the
cursor, and iOS may modify past text as new text adds context.

Once dictation is stopped, it starts sending `insertText` events with word fragments. When a past fragment is
altered, iOS sends a `beforeinput` event where `inputType` is null. In this case, perform a synchronous render
operation to set the editor to the correct state. Otherwise, scheduled render requests can process invalid
ranges and mess with the editor contents.
    @jorgemanrubia
    jorgemanrubia committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    776e1ce View commit details
    Browse the repository at this point in the history

  2. v2.1.6

    @jorgemanrubia
    jorgemanrubia committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c85546a View commit details
    Browse the repository at this point in the history