Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br_tse_eleicoes #534

Merged
merged 10 commits into from
Jun 5, 2024
Merged

br_tse_eleicoes #534

merged 10 commits into from
Jun 5, 2024

Conversation

rdahis
Copy link
Member

@rdahis rdahis commented Apr 8, 2024

No description provided.

@rdahis rdahis added table-approve Trigger action table-approve sync-dbt-schema Trigger actoin sync-dbt-schema labels Apr 8, 2024
@rdahis rdahis requested review from folhesgabriel and tricktx April 8, 2024 04:35
@rdahis rdahis self-assigned this Apr 8, 2024
@rdahis
Copy link
Member Author

rdahis commented Apr 18, 2024

@tricktx @arthurfg acho que terminei do meu lado. Se precisar podem passar um lint de novo. Se não tiverem mais questões podem aprovar por favor.

@tricktx
Copy link
Contributor

tricktx commented Apr 18, 2024

Dahis, normalmente usamos os seguintes testes:

  • Conexão com diretórios (ano, sigla_uf, mês, id_municipio e etc)
  • Chave única
  • Não nulidade das colunas

Segue o link de alguns schemas para exemplo:
https://github.com/basedosdados/queries-basedosdados/blob/main/models/br_denatran_frota/schema.yml
https://github.com/basedosdados/queries-basedosdados/blob/main/models/br_cgu_beneficios_cidadao/schema.yml
https://github.com/basedosdados/queries-basedosdados/blob/main/models/br_bcb_estban/schema.yml

arthurfg
arthurfg approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@arthurfg arthurfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que só falta incluir os testes que o patrick falou, já vou deixar o approve por conta do fuso rs

@rdahis
Copy link
Member Author

rdahis commented May 29, 2024

@tricktx @arthurfg subi mais um monte de mudanças e refiz praticamente todas as tabelas no BQ em development. Parece estar tudo basicamente passando nos testes. Dada a quantidade de mudanças, acho que vale vocês darem uma olhada de novo para ver se encontram algum erro antes de eu dar merge.

@tricktx
Copy link
Contributor

tricktx commented Jun 3, 2024

@rdahis eu fiz alguns comentários, reproduza para as demais colunas semelhantes.
Muito obrigado. :)

@rdahis rdahis merged commit 0def2e1 into main Jun 5, 2024
3 checks passed
@rdahis rdahis deleted the br_tse_eleicoes branch June 5, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tricktx tricktx tricktx left review comments

@laura-l-amaral laura-l-amaral laura-l-amaral left review comments

@arthurfg arthurfg arthurfg approved these changes

@folhesgabriel folhesgabriel Awaiting requested review from folhesgabriel

Assignees

@rdahis rdahis

Labels
sync-dbt-schema Trigger actoin sync-dbt-schema table-approve Trigger action table-approve
Projects
Roadmap de dados
Status: ✅ Finalizada!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdahis @tricktx @arthurfg @laura-l-amaral