Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Maven #1

wants to merge 9 commits into from

Conversation

eddgrant
Copy link

@eddgrant eddgrant commented Apr 4, 2012

Hi,

I wanted to use markdown-plus as a jar in my Groovy project but I noticed it doesn't exist in any Maven repo or as a binary .jar distribution. This got me thinking and I ended up mavenising the project. Thought I'd share my changes in case you were interested in pushing it to the Maven central repo so others can depend on markdown-plus Maven style?

The changes I have made are:

  • Pull everything in to the standard Maven file structure.
  • All the libs that were in lib are now Maven dependencies.
  • A mvn clean install will build the app jar, run the tests and build a .zip distribution which contains markdown-plus, all the required dependencies, the mdp bootstrap script and the templates folder.

A couple of issues I have noticed:

  • FreeMarkerProcessorTest seems to fail (and isn't included in the AllTests suite). I have added the @ignore annotation as I wasn't sure whether the failure was genuine or not.
  • For some reason I get an the error "initializationError(nineci.markdownplus.TestResultPair)" when I use Maven v2. However if I use Maven v3 then everything builds perfectly.

Oh, finally I'm afraid I'm a bit of a Git novice, hopefully I've gotten everything right in terms of my commits and the pull request but let me know if something doesn't work for any reason.

Anyway, hope this is of some use to you.

Cheers,

Edd

@basejump
Copy link
Owner

basejump commented Apr 4, 2012

Thanks but I have kind of abandoned this and will be releasing a wrapper around pegdown.
How are you using this out of curiosity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants