Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests: Chemprop - Combine Params to check #80

Open
2 tasks
c-w-feldmann opened this issue Sep 4, 2024 · 0 comments
Open
2 tasks

Unittests: Chemprop - Combine Params to check #80

c-w-feldmann opened this issue Sep 4, 2024 · 0 comments
Labels
status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date
Milestone
v1.0.0

Comments

@c-w-feldmann
Copy link
Collaborator

c-w-feldmann commented Sep 4, 2024 •
edited
Loading

Currently we have: DEFAULT_MULTICLASS_CLASSIFICATION_PARAMS and DEFAULT_BINARY_CLASSIFICATION_PARAMS which are partially overlapping. We should make a param-dict with the intersection and also extend to regression models.
TODO:

  • Adapt default params
  • Make param checks of models consistent in one function
@c-w-feldmann c-w-feldmann added status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date labels Sep 4, 2024
@c-w-feldmann c-w-feldmann mentioned this issue Sep 4, 2024
Merged
@c-w-feldmann c-w-feldmann added this to the v1.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@c-w-feldmann