Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72 make chemprop multiclass classification model #73

Merged
merged 25 commits into from
Sep 5, 2024
Merged

72 make chemprop multiclass classification model #73

merged 25 commits into from
Sep 5, 2024

Conversation

JenniferHem
Copy link
Collaborator

No description provided.

@JenniferHem JenniferHem self-assigned this Aug 26, 2024
@JenniferHem JenniferHem linked an issue Aug 26, 2024 that may be closed by this pull request
make chemprop multiclass classification model #72
Closed
JochenSiegWork
JochenSiegWork requested changes Aug 27, 2024
View reviewed changes
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Outdated Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Outdated Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Outdated Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Outdated Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Show resolved Hide resolved
c-w-feldmann
c-w-feldmann requested changes Aug 28, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Outdated Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Show resolved Hide resolved
molpipeline/estimators/chemprop/models.py Show resolved Hide resolved
@c-w-feldmann c-w-feldmann added the type: enhancement New feature or request label Aug 28, 2024
JochenSiegWork
JochenSiegWork requested changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already look very good. Just two small additions to test the correct behaviour of set_params

molpipeline/estimators/chemprop/models.py Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Show resolved Hide resolved
test_extras/test_chemprop/test_chemprop_pipeline.py Show resolved Hide resolved
c-w-feldmann
c-w-feldmann approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@c-w-feldmann c-w-feldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JenniferHem JenniferHem merged commit fa9363b into main Sep 5, 2024
14 checks passed
@JenniferHem JenniferHem deleted the 72-make-chemprop-multiclass-classification-model branch September 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferHemmerich JenniferHemmerich JenniferHemmerich left review comments

@JochenSiegWork JochenSiegWork JochenSiegWork approved these changes

@c-w-feldmann c-w-feldmann c-w-feldmann approved these changes

Assignees

@JenniferHem JenniferHem

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make chemprop multiclass classification model
4 participants
@JenniferHem @JenniferHemmerich @c-w-feldmann @JochenSiegWork