Skip to content

Commit

Permalink
Remove more dead code
Browse files Browse the repository at this point in the history
  • Loading branch information
basil committed Aug 27, 2024
1 parent 96378c1 commit 863e632
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,7 @@ public boolean installPlugins(final PluginSpec... specs) throws UnableToResolveD
tickPluginToInstall(n);
}

// Temporary until https://github.com/jenkinsci/jenkins/pull/8025 is in LTS
if (find(by.button("Download now and install after restart")) != null) {
control(by.button("Download now and install after restart")).clickAndWaitToBecomeStale();
} else {
control(by.button("Update")).clickAndWaitToBecomeStale();
}
control(by.button("Update")).clickAndWaitToBecomeStale();
}
}

Expand Down
7 changes: 1 addition & 6 deletions src/test/java/plugins/JobDslPluginTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -916,13 +916,8 @@ public void are_columns_created() {
assertThat(view, containsColumnHeader("Last Duration"));

String searchText = "Schedule a Build for " + job1.name;
// behaviour change in https://github.com/jenkinsci/jenkins/pull/6084
WebElement webElement = view.getElement(By.cssSelector(String.format("a[tooltip='%s']", searchText)));
if (webElement != null) {
assertThat(view, containsLinkWithTooltip(searchText));
} else {
assertThat(view, containsSvgWithText(searchText));
}
assertThat(view, containsLinkWithTooltip(searchText));
}

/**
Expand Down

0 comments on commit 863e632

Please sign in to comment.