Skip to content

Commit

Permalink
Remove config.yml from service worker to avoid caching issues
Browse files Browse the repository at this point in the history
  • Loading branch information
bastienwirtz committed Mar 23, 2020
1 parent 22555b5 commit 4b87511
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Homepage configuration
# See https://fontawesome.com/icons for icons options

title: "Demo homepage"
title: "Demo dashboard"
subtitle: "Homer"
logo: "assets/logo.png"
# icon: "fas fa-skull-crossbones" Optional icon
Expand All @@ -20,11 +20,11 @@ message:
links:
- name: "ansible"
icon: "fab fa-github"
url: "https://github.com/xxxxx/ansible/"
url: "https://github.com/bastienwirtz/homer"
target: '_blank' # optionnal html a tag target attribute
- name: "Wiki"
icon: "fas fa-book"
url: "https://wiki.xxxxxx.com/"
url: "https://www.wikipedia.org/"

# Services
# First level array represent a group.
Expand Down
1 change: 0 additions & 1 deletion worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ self.addEventListener('install', event => {
cache.addAll([
'.',
'index.html',
'config.yml',

This comment has been minimized.

Copy link
@fbartels

fbartels Apr 29, 2020

Contributor

While removing config.yml from the files the service worker caches will prevent issues some others have with displaying outdated information this also completely breaks the offline functionality of Homer. When the file is not cached and there is no connection to the server it will now simply show an empty page.

'app.css',
'app.js',
'vendors/vue.min.js',
Expand Down

0 comments on commit 4b87511

Please sign in to comment.