FreshRSS custom service. #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for homer-demo-content ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bastienwirtz
requested changes
Aug 6, 2023
There was a problem hiding this comment.
Thanks for this contribution too @thedroid!
It would also be nice to have the dummy data for this one if possible.
src/components/services/FreshRSS.vue
Outdated
|
|
||
| this.fetch(`/api/greader.php/reader/api/0/subscription/list?output=json`, { headers }) | ||
| .then((subscription) => { | ||
| this.subscriptions = 0; |
There was a problem hiding this comment.
You should be able to set subscriptions to 0 in the declaration, line 37, and remove this line
src/components/services/FreshRSS.vue
Outdated
| console.error(e); | ||
| this.serverError = true; | ||
| }); | ||
| this.fetch(`/api/greader.php/reader/api/0/unread-count?output=json`, { headers }) |
There was a problem hiding this comment.
Wrong indentation, could you run a yarn lint ?
src/components/services/FreshRSS.vue
Outdated
| }); | ||
| this.fetch(`/api/greader.php/reader/api/0/unread-count?output=json`, { headers }) | ||
| .then((unreadcount) => { | ||
| this.unread = 0; |
There was a problem hiding this comment.
Same here about the initial value.
bastienwirtz
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Checklist:
config.ymlfile