Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow disabling IPv6 #696

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

tnyeanderson
Copy link
Contributor

Description

Allows the user to set the IPV6_DISABLE environment variable to a non-empty value to disable lighttpd listening on IPv6.

Fixes: #648

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 170cefd
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/6513c409119040000853ed25
😎 Deploy Preview https://deploy-preview-696--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tnyeanderson tnyeanderson marked this pull request as ready for review September 8, 2023 05:48
@tnyeanderson
Copy link
Contributor Author

Hey @bastienwirtz , anything I need to do to get this moving? :)

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tnyeanderson

Thanks for your contribution, and sorry for the delay !
A few detail but it looks good.

ipv6.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@tnyeanderson
Copy link
Contributor Author

Should be good to go. Thanks @bastienwirtz !

lighttpd-ipv6.sh Outdated Show resolved Hide resolved
@tnyeanderson
Copy link
Contributor Author

Good catch! lol

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @tnyeanderson, I'll test that asap and it should be good to go

@bastienwirtz
Copy link
Owner

Works fine @tnyeanderson, thanks again !

@bastienwirtz bastienwirtz merged commit 9b77b47 into bastienwirtz:main Oct 21, 2023
7 checks passed
@tnyeanderson tnyeanderson deleted the feat-disable-ipv6 branch October 21, 2023 18:38
@gstrauss
Copy link

FYI: lighttpd 1.4.72 will issue a warning if IPv6 is not available and will continue without listening on that socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Option to disable ipv6
3 participants