Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping service timeout #825

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

Canti23
Copy link
Contributor

@Canti23 Canti23 commented Nov 13, 2024

Description

Added support for the timeout option for the Ping service. The default value is 2000 ms, which should be sufficient for most services.

Fixes #804

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion regarding the doc, aside from that, it's all good. Thanks @Canti23 !

docs/customservices.md Outdated Show resolved Hide resolved
Co-authored-by: Bastien Wirtz <[email protected]>
@bastienwirtz bastienwirtz merged commit 80e458f into bastienwirtz:main Nov 14, 2024
1 check passed
@Canti23
Copy link
Contributor Author

Canti23 commented Nov 14, 2024

Thanks, thought about that, but haven't figured out how to write it succinctly :)

@Canti23 Canti23 deleted the ping_service_timeout branch November 14, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping-Service should use a timeout
2 participants