AnimatorNode cache for ModelAnimator #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_animator_child_with_id()
searches for child AnimatorNodes recursively using a depth-first search, which in practice is pretty slow. It gets called numerous times for many (most?) animated entities and is the source of a ton of lag. This simply implements a cache of these nodes by id for ModelAnimator, improving performance significantly.As a side note, do we care too much about labeling the offsets of struct members? I understand why they're there for decomp, but updating them here is tedious and I'm not sure if there's a point.