Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'more than' and 'less than' statements in verify and try to verify is #41

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

peterparser
Copy link

@peterparser peterparser commented Feb 23, 2024

This PR adds the support for more than and less than keywords in verify and try to verify is statements.

When I was implementing some test cases, I found that this two statements could be useful instead of parsing the data from the kubectl output and do the comparison in a bash fashion.

In case some other changes are needed, please, let me know.

Copy link
Member

@vincent-zurczak vincent-zurczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterparser!

This is a great contribution.
Thank you!

I added few comments, mostly cosmetic.

lib/detik.bash Outdated Show resolved Hide resolved
lib/utils.bash Outdated Show resolved Hide resolved
lib/utils.bash Outdated Show resolved Hide resolved
tests/test.detik.try.to.verify.is.bats Outdated Show resolved Hide resolved
@peterparser
Copy link
Author

Hi @peterparser!

This is a great contribution. Thank you!

I added few comments, mostly cosmetic.

Thanks @vincent-zurczak! I've made the changes, also I changed the tests from testing if more is present I now check for more than, the same happens with less. Thanks again

@brokenpip3
Copy link

brokenpip3 commented Feb 23, 2024

🚀

@peterparser peterparser marked this pull request as ready for review February 23, 2024 09:20
@vincent-zurczak vincent-zurczak merged commit 457549d into bats-core:master Feb 23, 2024
2 checks passed
@vincent-zurczak
Copy link
Member

vincent-zurczak commented Feb 23, 2024

@peterparser Again, thank you for this contribution.
I merged it and I was about to create a new tag when I noticed the README documentation had not been updated. Do you think you could do that please?

@peterparser
Copy link
Author

@peterparser Again, thank you for this contribution. I merged it and I was about to create a new tag when I noticed the README documentation had not been updated. Do you think you could do that please?

Sure, I will update it and put some examples in the examples folder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants