Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log tracebacks for tasks, log errors properly #730

Merged
merged 3 commits into from
Apr 26, 2024
Merged

log tracebacks for tasks, log errors properly #730

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5050f8c
log tracebacks for tasks and log errors
acrantel Jan 22, 2024
2cdcbc1
define errReport var
acrantel Jan 22, 2024
6102900
empty
acrantel Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions saturn/pkg/saturn/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bytes"
"context"
"fmt"
"runtime/debug"

"github.com/rs/zerolog"
"github.com/rs/zerolog/log"
Expand Down Expand Up @@ -92,10 +93,10 @@ func (t *Task) Run(ctx context.Context, r Reporter) (err error) {
panic(r)
}
if err != nil {
// TODO: log a traceback
log.Ctx(ctx).Error().Msg(string(debug.Stack()))
}
if err = t.FinalizeReport(ctx, r); err != nil {
err = fmt.Errorf("t.FinalizeReport: %v", err)
if errReport := t.FinalizeReport(ctx, r); errReport != nil {
err = fmt.Errorf("%v, t.FinalizeReport: %v", err, errReport)
}
if t.status.Retryable() {
err = fmt.Errorf("task not complete: %v", err)
Expand Down
Loading