-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factories Loaders and Token Validity #746
Conversation
Not to toot my own horn but that commit is pretty epic some real late night success 😎 |
Great job! I skimmed the code and it looks good, is there anything specific in this PR you'd want me to take a look at? |
23d91de
to
3b6ed07
Compare
3b6ed07
to
ac579e7
Compare
@acrantel I fixed the token validity issue!! Basically just added an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does the following:
Need to test: