Rating History API #780
Rating History API #780
Conversation
|
@Desperationis The home page chart looks a little odd (you can see if you pull this branch down). Also, I think we should implement a "loading" state for the chart component! Think you could take those tasks on? 😎 |
|
I added a loading status for the chart. It's not the spiny thing you wanted, but you can customize the text and style to whatever you want. Also, the reason the chart looks weird on the home page is because, by the looks of it, there is no data being returned for that episode. If you change the episode to a different year (2023 / 2022) it works just fine. I added a "No data available" status for this |
|
Also, there is a really weird error and I have absolutely no clue where it is coming from. It doesn't stop the program from running, but there's a type error in console |
Couldn't figure this out... just squashed it with a try catch haha 😆 |
| try { | ||
| if (loading) myChart.showLoading(loadingMessage ?? "Loading..."); | ||
| else myChart.hideLoading(); | ||
| } catch (e) { | ||
| // Ignore internal highcharts errors... | ||
| } |
There was a problem hiding this comment.
I think the reason there is an error here is because myChart.options is not defined. Could we define it before we call showLoading?
There was a problem hiding this comment.
Ok trying to do that causes other errors nvm 💀
There was a problem hiding this comment.
actually i think we may just need to put it in a useeffect.
|
How are we testing this? There seems to be ranking data in the staging database for Battlecode 2022 but it is not showing up in the chart. |
@acrantel I see this in my staging... did you mean that there is more data that doesn't show up? Or like is there just none for you? 
|
I see "No data found to display". This happens both when I'm logged in and not logged in. |
|
Wacky... ideas for testing?? Do we have django tests? |
|
NVM disregard what I was saying about no data, I was testing it on staging backend when I should have been testing with local backend 💀 |
Adds a rating history API for multiple teams at once! Also, connects the home page chart to said api.
Closes #788 🚀