Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Matching: Allow passing class as subnet (2.0 version) #200

Closed
vpratz opened this issue Oct 8, 2024 · 2 comments
Closed

Flow Matching: Allow passing class as subnet (2.0 version) #200

vpratz opened this issue Oct 8, 2024 · 2 comments
Labels
feature New feature or request

Comments

@vpratz
Copy link
Collaborator

vpratz commented Oct 8, 2024

This is probably already planned: FlowMatching currently only accepts strings for the subnet argument. Allowing classes as well would help with modularity, as it enables easily plugging in custom networks for power users, without sacrificing ease of use for others.
Handling the case in utils.find_network and initializing the class there might be sufficient to enable this.

@marvinschmitt
Copy link
Member

I like the idea and second the proposal.

Would you mind drafting a PR that implements this? Based on your description it should be quite straightforward.

@marvinschmitt marvinschmitt added the feature New feature or request label Oct 8, 2024
vpratz added a commit to vpratz/BayesFlow that referenced this issue Oct 9, 2024
* in addition to strings, type (i.e., uninstantiated classes) are
  accepted as well

* allows easy use of user-defined networks
stefanradev93 pushed a commit that referenced this issue Oct 9, 2024
* Allow calling find_network with type (#200)

* in addition to strings, type (i.e., uninstantiated classes) are
  accepted as well

* allows easy use of user-defined networks

* Allow tyoe in find_network: update type hints
@marvinschmitt
Copy link
Member

closed by #201

stefanradev93 pushed a commit that referenced this issue Oct 22, 2024
* Allow calling find_network with type (#200)

* in addition to strings, type (i.e., uninstantiated classes) are
  accepted as well

* allows easy use of user-defined networks

* Allow tyoe in find_network: update type hints

* Complete Consistency Model implementation

* Add Consistency Model to networks

* Consistency Models: minor fixes for Jax and TF

* Consistency Models: Fix to the sampling routine

* Documentation: Consistency Model example notebook

* cosmetic updates to the consistency model notebook

---------

Co-authored-by: Marvin Schmitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants