Allow calling find_network with type (#200) #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vpratz
commented
Oct 9, 2024
vpratz
commented
- in addition to strings, accept type (i.e., uninstantiated classes) as well
- allows easy use of user-defined networks
- adapt type hints to reflect this change
* in addition to strings, type (i.e., uninstantiated classes) are accepted as well * allows easy use of user-defined networks
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #201 +/- ##
==========================================
- Coverage 52.16% 52.16% -0.01%
==========================================
Files 142 142
Lines 3213 3217 +4
==========================================
+ Hits 1676 1678 +2
- Misses 1537 1539 +2 ☔ View full report in Codecov by Sentry. |
|
closes #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.