-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete implementation of Consistency Models #205
Conversation
* in addition to strings, type (i.e., uninstantiated classes) are accepted as well * allows easy use of user-defined networks
Thanks for the PR @vpratz, that's fantastic! Since you were creating a notebook to test the implementation anyway, would you mind adding that to the |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #205 +/- ##
==========================================
+ Coverage 53.21% 53.87% +0.65%
==========================================
Files 142 142
Lines 3266 3265 -1
==========================================
+ Hits 1738 1759 +21
+ Misses 1528 1506 -22 ☔ View full report in Codecov by Sentry. |
Thanks for your feedback, I have added the notebook. I included a background section that turned out to be not very minimal, feel free to modify/shorten as you see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR. I made some changes to the tutorial notebook:
- fix a few typos
- adjust
$x \to \theta$ in the initial description of consistency models to be consistent (haha) with our subsequent conditional version, where$\theta$ is the target variable$x$ is the conditioning variable. - use hyperparameters from the Consistency Model Posterior Estimation paper:
- empirical variance of the prior samples as
sigma2
max_time=10
- empirical variance of the prior samples as
We can merge from my side.
@stefanradev93 @LarsKue before we merge:
- Any feedback or change requests from your side?
- What's the strategy for adding tests?
Completes the implementation of Consistency Models.
I tested the implementation as a drop in replacement in the two moons notebook.