Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous-time consistency models #234

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

vpratz
Copy link
Collaborator

@vpratz vpratz commented Nov 2, 2024

Implements continuous-time consistency models as described in [1].

I observe differences in the quality of the samples depending on the backend (all else equal) that I cannot explain yet. Tensorflow performs consistenly better than Jax and PyTorch. If you find any indications for the reasons of this difference, please let me know.

[1] Lu, C., & Song, Y. (2024).
Simplifying, Stabilizing and Scaling Continuous-Time Consistency Models
arXiv preprint arXiv:2410.11081

Implements continuous-time consistency models as described in [1]

[1] Lu, C., & Song, Y. (2024).
    Simplifying, Stabilizing and Scaling Continuous-Time Consistency Models
    arXiv preprint arXiv:2410.11081
@vpratz vpratz added feature New feature or request v2 labels Nov 2, 2024
@vpratz vpratz requested a review from stefanradev93 November 2, 2024 17:12
@vpratz vpratz self-assigned this Nov 2, 2024
@vpratz
Copy link
Collaborator Author

vpratz commented Nov 3, 2024

First observation: Loading a model trained in Tensorflow in Jax works with equal quality, so the difference is somewhere in the training process, not in the sampling.

@vpratz
Copy link
Collaborator Author

vpratz commented Nov 3, 2024

The difference was caused by a coincidence, which led me to discover an error in the loss calculation. It is now fixed, and all backends lead to similar results.
@stefanradev93 I think the code is now ready to review. We should optimize the schedule for the sampling, but we can do this at a later point in time.

@stefanradev93 stefanradev93 merged commit 5d61cd0 into bayesflow-org:dev Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants