Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics module #235

Merged
merged 33 commits into from
Nov 18, 2024
Merged

Diagnostics module #235

merged 33 commits into from
Nov 18, 2024

Conversation

jerrymhuang
Copy link
Collaborator

@jerrymhuang jerrymhuang commented Nov 4, 2024 •
edited
Loading

The diagnostics module is now migrated under the main repo (continued from #229).

The key module elements have been reproduced through the Linear Regression notebook.

@jerrymhuang jerrymhuang added duplicate This issue or pull request already exists feature New feature or request refactoring Some code shall be redesigned v2 labels Nov 4, 2024
@jerrymhuang jerrymhuang added this to the BayesFlow 2.0 milestone Nov 4, 2024
@jerrymhuang jerrymhuang self-assigned this Nov 4, 2024
@jerrymhuang jerrymhuang linked an issue Nov 4, 2024 that may be closed by this pull request
Remove code duplication from diagnostics module #138
Closed
jerrymhuang and others added 22 commits November 3, 2024 23:13
@jerrymhuang
Add confusion_matrix
104f726
@jerrymhuang
Merge branch 'dev' into diagnostics
9f66871
@jerrymhuang
Remove duplicate code for layout configuration
ae2a6a3
@jerrymhuang
Simplify pre-processing for plot_recovery and plot_z_score_contraction
bf9066a
@jerrymhuang
Simplify prettify process for z_score and recovery
b522a7e
@jerrymhuang
Simplify preprocessing for plot_sbc_ecdf and plot_sbc_histograms
609c89c
@jerrymhuang
Simplify labeling
1beb585
@jerrymhuang
Reformat
fd24587
@jerrymhuang
Make plot_distribution_2d more compatible
8fde9e9
@jerrymhuang
Update quickstart notebook with working prior checks
a7fd398
@jerrymhuang
Improve compatibility for plot_losses and plot_prior_2d
04bd262
@jerrymhuang
Update quickstart notebook with loss trajectory
a4d4452
@jerrymhuang
Minor fix of plot_utils, start adding tests for diagnostics
18f0514
@stefanradev93
Pre-final version WIP
05a4978
@jerrymhuang
Merge branch 'dev' into diagnostics
0e956b5
@jerrymhuang
Minor changes in 2d plots; update and test plot_z_score_contraction
3090ea7
@jerrymhuang
Update and test plot_sbc_histograms
5cb5847
@jerrymhuang
Update plot_calibration_curves (WIP)
5462ecf
@jerrymhuang
Minor refactors: change global color schemes, complete type casts, fu…
2868f96 
…rther simplify plot_losses
@jerrymhuang
Add detailed callback for loss trajectory
ad59eae
@jerrymhuang
Generalize preprocessing utilities from samples to variables
15bc4ab
@jerrymhuang
Generalize add_metric
16436c2
@jerrymhuang jerrymhuang marked this pull request as ready for review November 15, 2024 23:51
@jerrymhuang
Copy link
Collaborator Author

jerrymhuang commented Nov 15, 2024 •
edited
Loading

Currently, the following diagnostics utilities have been tested and are functional:

  • plot_losses
  • plot_recovery
  • plot_sbc_ecdf
  • plot_sbc_histogram
  • plot_z_score_contraction
  • plot_samples_2d (as a template for plot_prior_2d and plot_posterior_2d, to be continued)

Some further improvement is possible. The other utilities are available but may need further adjustments due to a lack of example notebooks to test.

Any suggestions and feedback are welcome.

@stefanradev93 stefanradev93 merged commit b9b6b9a into dev Nov 18, 2024
1 of 13 checks passed
@stefanradev93 stefanradev93 deleted the diagnostics branch November 18, 2024 22:22
@elseml elseml mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jerrymhuang jerrymhuang

Labels
duplicate This issue or pull request already exists feature New feature or request refactoring Some code shall be redesigned
Projects
bayesflow development
Status: Done
Milestone
BayesFlow 2.0
Development

Successfully merging this pull request may close these issues.

Remove code duplication from diagnostics module
2 participants
@jerrymhuang @stefanradev93