Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK:228740 | Upgrade logback version #810

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

VERMARAVI-BV
Copy link
Contributor

Github Issue

228740

What Are We Doing Here?

Upgrading logback version to 1.2.3 to reduce vulnerabilities.

image

How to Test and Verify

  1. Check out this PR
  2. Run Command X, Click Button Y
  3. Profit

Risk

Level

Low, Medium, or High. Give an indication of what you think is the level of change introduced by this PR. High means a massive change to a core functionality.
Low means a really minor change that shouldn't have any regression effect.

Required Testing

Smoke, Regression, or Manual. (All changes except documentation need smoke
testing at a minimum).

Risk Summary

Add one or a few complete sentences about the possible risks or concerns for
this change.

Code Review Checklist

  • Tests are included. If not, make sure you leave us a line or two for the reason.

  • Pulled down the PR and performed verification of at least being able to
    build and run.

  • Well documented, including updates to any necessary markdown files. When
    we inevitably come back to this code it will only take hours to figure out, not
    days.

  • Consistent/Clear/Thoughtful? We are better with this code. We also aren't
    a victim of rampaging consistency, and should be using this course of action.
    We don't have coding standards out yet for this project, so please make sure to address any feedback regarding STYLE so the codebase remains consistent.

  • PR has a valid summary, and a good description.

@VERMARAVI-BV VERMARAVI-BV requested a review from a team as a code owner January 17, 2024 11:24
@VERMARAVI-BV VERMARAVI-BV force-pushed the feature/DATASTORAGE-228740 branch 19 times, most recently from 44bfbf1 to 1c0eb88 Compare January 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant