Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bazel test support to javascript --config=debug preset #825

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Apr 25, 2024

@jfirebaugh pointed out that we are missing this.

Tested downstream in rules_js:

bazel test //examples/js_binary:test_test --config=debug
WARNING: Streamed test output requested. All tests will be run locally, without sharding, one at a time
INFO: Analyzed target //examples/js_binary:test_test (0 packages loaded, 0 targets configured).
Debugger listening on ws://127.0.0.1:9229/385833a3-8f5e-437e-804d-a888a56bf7dd
For help, see: https://nodejs.org/en/docs/inspector
[1 / 2] Testing //examples/js_binary:test_test; 4s darwin-sandbox

@gregmagolan gregmagolan force-pushed the support_bazel_test_with_config_debug branch from 535f02e to ac60267 Compare April 25, 2024 23:10
Copy link

aspect-workflows bot commented Apr 25, 2024

Test

1 test target passed

Targets
//lib/tests/bazelrc_presets/all:update_aspect_bazelrc_presets_6_test [k8-opt] 66ms

Total test execution time was 66ms. 226 tests (99.6%) were fully cached saving 38s.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 660ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 578ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 52ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the support_bazel_test_with_config_debug branch from ac60267 to 0643541 Compare April 25, 2024 23:16
@gregmagolan gregmagolan merged commit 4141338 into main Apr 25, 2024
71 checks passed
@gregmagolan gregmagolan deleted the support_bazel_test_with_config_debug branch April 25, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants