Remove dep on android ndk. #1305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
cc @ahumesky |
|
@jin I have a special question: what if one aar contains so files and header files that bundled by prefab(https://google.github.io/prefab/)(my first thought is that it's not the RJE's responsibility)? Looks like RJE only resolves class files of one dependency for Android? |
shs96c
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not using any NDK utility in RJE, and we shouldn't be in the business of doing so. The only android dep is aar_import, so it should be clear to drop our dependency on the NDK.
Also remove the aar_import-based test for
override_targets: we already have sufficient coverage using the opentelemetry/java_library test case in the sametests/integration/override_targets/BUILDfile.The SDK is still needed for
//tests/unit/aar_importtargets.