Validate versions in metadata.json files are sorted (#1431)

bazelbuild · Feb 5, 2024 · 87c1e07 · 87c1e07
1 parent 3cc45a5
commit 87c1e07
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/modules/buildozer/metadata.json b/modules/buildozer/metadata.json
@@ -11,8 +11,8 @@
         "github:fmeum/buildozer"
     ],
     "versions": [
-        "6.4.0.2",
-        "6.4.0"
+        "6.4.0",
+        "6.4.0.2"
     ],
     "yanked_versions": {}
 }
diff --git a/modules/rules_xcodeproj/metadata.json b/modules/rules_xcodeproj/metadata.json
@@ -16,13 +16,13 @@
         "github:MobileNativeFoundation/rules_xcodeproj"
     ],
     "versions": [
-        "1.0.0rc1",
-        "1.0.0rc2",
-        "1.0.0rc3",
         "0.12.0",
         "0.12.2",
         "0.12.3",
         "1.0.1",
+        "1.0.0rc1",
+        "1.0.0rc2",
+        "1.0.0rc3",
         "1.1.0",
         "1.2.0",
         "1.3.0",

diff --git a/tools/bcr_validation.py b/tools/bcr_validation.py
@@ -288,6 +288,12 @@ def validate_all_metadata(self):
         self.report(BcrValidationResult.FAILED, f"Failed to load {module_name}'s metadata.json file: " + str(e))
         has_error = True
         continue
+
+      sorted_versions = sorted(metadata["versions"], key=Version)
+      if sorted_versions != metadata["versions"]:
+        self.report(BcrValidationResult.FAILED, f"{module_name}'s metadata.json file is not sorted by version.\n Sorted versions: {sorted_versions}.\n Original versions: {metadata['versions']}")
+        has_error = True
+
       for version in metadata["versions"]:
         if not self.registry.contains(module_name, version):
           self.report(BcrValidationResult.FAILED, f"{module_name}@{version} doesn't exist, but it's recorded in {module_name}'s metadata.json file.")